RFR: 8322619: Parts of SG no longer update during rendering - overlapping - culling - dirty [v4]
eduardsdv
duke at openjdk.org
Thu Jul 4 07:43:25 UTC 2024
On Wed, 3 Jul 2024 20:26:35 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
>> eduardsdv has updated the pull request incrementally with four additional commits since the last revision:
>>
>> - JDK-8322619: Move to the test.robot.com.sun.prism package and use TOLERANCE when comparing colors
>> - JDK-8322619: Add copyright header
>> - JDK-8322619: Add waiting for rendering before taking a snapshot
>> - JDK-8322619: Remove unused field; Add stage.setAlwaysOnTop(..); stage.initStyle(..)
>
> The newer version still fails on my Mac machine.
>
> Attaching modified test that executes as expected on my Windows and Mac machines.
> The main change that makes it work on Mac is the change in `checkColor()` method.
> There are some additional minor changes, and I recommend to keep those.
> Please do test on your machines.
>
> [NGNodeDirtyFlagTest.java.zip](https://github.com/user-attachments/files/16090444/NGNodeDirtyFlagTest.java.zip)
Yes, the test with your suggestion also works under Windows. Thank you, @arapte.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1451#issuecomment-2208319678
More information about the openjfx-dev
mailing list