RFR: 8322619: Parts of SG no longer update during rendering - overlapping - culling - dirty [v5]

[Kevin Rushforth]

On Fri, 17 May 2024 12:36:22 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:

>> Florian Kirmaier has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - JDK-8322619: Add test
>>  - Revert "JDK-8322619: Clear dirty flag on the node and all its children if they are skipped due to visible==false or opacity==0"
>>    
>>    This reverts commit 5f9f1574515c078c1fd0dccd476325090a0b284d.
>
> Sorry for creating the CSR, it was an accident.
> 
> Now that Eduard has both created an alternative solution, but also has reviewed that this solution is correct, and provided an unit-test - I think this (or the other) PR is ready to move forwards.
> 
> @kevinrushforth 
> What do you think?
> 
> This is still quite a fundamental bug which is probably quite prevalent, 
> because when it happens it is really hard to notice it.
> But it probably happens more often than we think.

@FlorianKirmaier since it looks like we are going with PR #1451 as the solution, please close this PR (or move it to Draft until #1451 is integrated and then close it).

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1310#issuecomment-2208904453