RFR: 8335218: Eclipse Config: Remove Gradle Integration
Andy Goryachev
angorya at openjdk.org
Mon Jul 8 17:38:37 UTC 2024
On Mon, 8 Jul 2024 15:01:08 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:
>> @lukostyra thank you for testing! there should be no changes made to the .project or any other files. could you reset your workspace and maybe try again?
>>
>> if the changes do appear, what are they?
>
>> if the changes do appear, what are they?
>
> @andy-goryachev-oracle I tried it again after clearing the workspace folder and they do appear again.
>
> I also had some old git index settings applied which hid most of .project changes. Turns out that basically all `.project` files are modified, but I don't know if we can really help that - even when you tell VSCode Java plugin to not populate the workspace with project files, it sees they exist in the repo and uses/modifies them anyway. I saw a few issues on GitHub regarding this with no real resolution.
>
> All of `.project`s have the same bit added (seems like something internal for the plugin):
>
> <filteredResources>
> <filter>
> <id>1720448829339</id>
> <name></name>
> <type>30</type>
> <matcher>
> <id>org.eclipse.core.resources.regexFilterMatcher</id>
> <arguments>node_modules|.git|__CREATED_BY_JAVA_LANGUAGE_SERVER__</arguments>
> </matcher>
> </filter>
> </filteredResources>
>
>
> Regardless, the change does prevent the plugin from modifying `.classpath` files, which lets the project index and build properly. I don't expect to ever have to tinker with `.project` files for any reason, so it's good enough for me.
Thank you @lukostyra for checking!
> All of `.project`s have the same bit added (seems like something internal for the plugin):
This change looks innocuous enough - at least it does not break the build. Why VSCode does it is a mystery, but I suppose that's a bug in VSCode plugin.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1491#issuecomment-2214793261
More information about the openjfx-dev
mailing list