RFR: 8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first tooltip that is shown before it is displayed [v9]

[Kevin Rushforth]

On Mon, 8 Jul 2024 22:25:07 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> tests/system/src/test/java/test/robot/javafx/scene/TooltipTest.java line 64:
>> 
>>> 62: 
>>> 63:     private static void assertTooltipShowDelay(long tooltipShowTime, long expectedTime) {
>>> 64:         assertTooltipShowDelay(tooltipShowTime, expectedTime, 50);
>> 
>> If I change this to 100, then all tests pass most of the time. So maybe 150 or 200 would be a better maximum delta?
>> 
>> If you do make this change, then you will need to find all of the three-arg calls with a maxDifference less than that and change them to the two-arg version.
>
> even with max=200 we might see occasional failures due to load or other circumstances.
> 
> I wonder a better approach would be to check whether the measurement of the delay falls sufficiently outside of the default 1000 ms (which in itself might be more than that)?

We have many tests that will occasionally fail with a heavily loaded system.

The question is whether we can come up with a max delta that we can reliably use that is less than the difference between the default value and the test value. Otherwise, we can't distinguish them.

On two different test systems, both of which fail pretty consistently with  50 msec, I see a 100% pass rate over several tries with 150 msec. More testing is needed.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1394#discussion_r1669410740