RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v18]
Johan Vos
jvos at openjdk.org
Tue Jul 9 09:15:43 UTC 2024
On Wed, 19 Jun 2024 12:39:11 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
>> Johan Vos has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - process more reviewer comments
>> - Process reviewer comments
>
> tests/system/src/test/java/test/com/sun/javafx/tk/quantum/SystemMenuBarTest.java line 1:
>
>> 1: /*
>
> This test file is moved from a different location, could do `git mv` instead removing and adding.
I manually reverted the add/remove part, and replaced it with `git mv`. I assume/hope that by squashing the commits, the add/remove will not be part of the change.
> tests/system/src/test/java/test/com/sun/javafx/tk/quantum/SystemMenuBarTest.java line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
>
> This file is moved, so the copyright should reflect same. Should be : `2023, 2024`
right, done.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1283#discussion_r1670094429
PR Review Comment: https://git.openjdk.org/jfx/pull/1283#discussion_r1670091229
More information about the openjfx-dev
mailing list