[External] : Re: consistent naming for tests
Kevin Rushforth
kevin.rushforth at oracle.com
Tue Jul 9 16:02:50 UTC 2024
> https://github.com/andy-goryachev-oracle/jfx/pull/9
Hmm. I don't really like the abbreviations. They would change something
that is self-explanatory to something completely opaque, although I see
you did leave the descriptive name as a comment.
-- Kevin
On 7/9/2024 8:37 AM, Andy Goryachev wrote:
>
> Have you tried building in Eclipse on the latest Linux Mint? Or
> building on an EncFS mount?
>
> I don't know why Mint decided to use EncFS knowing its issues, and I
> suppose I can try fixing my setup (it's a default Mint installation),
> but I was quite surprised myself and thought that it might be just as
> easy to fix the tests... here is how the fix might look:
>
> https://github.com/andy-goryachev-oracle/jfx/pull/9
>
> -andy
>
> *From: *John Hendrikx <john.hendrikx at gmail.com>
> *Date: *Tuesday, July 9, 2024 at 08:22
> *To: *Andy Goryachev <andy.goryachev at oracle.com>, Johan Vos
> <johan.vos at gluonhq.com>, openjfx-dev <openjfx-dev at openjdk.org>
> *Subject: *[External] : Re: consistent naming for tests
>
> On 09/07/2024 16:52, Andy Goryachev wrote:
>
> Two test files consistently generate an error in Eclipse
>
> - ObservableValueFluentBindingsTest
> - LazyObjectBindingTest
>
> I admit I have a weird setup (EncFS on Linux Mint running on
> MacBook Pro), and it only manifests itself in Eclipse and not in
> the gradle build - perhaps Eclipse actually verifies the removal
> of files?
>
> Anyway, a suggestion - if you use @Nested, please keep the class
> names /short/.
>
> This is not an Eclipse bug as I never encounter such issues. 143
> characters is rather short these days, but I suppose we could limit
> the nesting a bit. Still, I'd look into a way to alleviate this
> problem in your setup, sooner or later this is going to be a problem.
>
> --John
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/openjfx-dev/attachments/20240709/8652aaa9/attachment.htm>
More information about the openjfx-dev
mailing list