RFR: 8323706: Move SimpleSelector and CompoundSelector to internal packages [v3]

[Andy Goryachev]

On Thu, 18 Jan 2024 23:57:05 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> John Hendrikx has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>> 
>>  - Merge branch 'master' of https://git.openjdk.org/jfx into feature/selectors-to-private-api-standalone
>>  - Add since tags
>>  - Move SimpleSelector and CompoundSelector to private classes
>
> modules/javafx.graphics/src/main/java/javafx/css/Selector.java line 96:
> 
>> 94:      * @return a match, never {@code null}
>> 95:      */
>> 96:     public final Match createMatch() {
> 
> This is a compatible change only because this class is sealed. I do have a question, though, about whether it should remain abstract.

I agree with Kevin here: the implementation should be moved to respective child classes.

If Match constructor is not public, then we should create a factory method in a helper, for example.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1333#discussion_r1670911089