[External] : Re: consistent naming for tests

[John Hendrikx]

Then I can't explain why it doesn't fail on Gradle; it must be 
generating similar named classes then, but perhaps at a different 
location (not on encfs) ?.

--John

On 09/07/2024 19:35, Andy Goryachev wrote:
>
> Anonymous classes are named $1.  Nested classes retain their name.
>
> From the ticket:
>
> https://bugs.openjdk.org/browse/JDK-8334497
>
> Could not delete: 
> /home/ag/Projects/jfx-2/jfx/rt/modules/javafx.base/testbin/test/javafx/beans/value/ObservableValueFluentBindingsTest$When_flatMap_Called$WithNotNullReturns_ObservableValue_Which$WhenObservedForInvalidations$AndWhenUnobserved.class.
>
> -andy
>
> *From: *John Hendrikx <john.hendrikx at gmail.com>
> *Date: *Tuesday, July 9, 2024 at 10:31
> *To: *Andy Goryachev <andy.goryachev at oracle.com>, Johan Vos 
> <johan.vos at gluonhq.com>, openjfx-dev <openjfx-dev at openjdk.org>
> *Subject: *Re: [External] : Re: consistent naming for tests
>
> Perhaps it is something Eclipse does differently. Normally nested 
> classed are numbered ($1, $2), so perhaps ecj is compiling these with 
> differently filenames.
>
> --John
>
> On 09/07/2024 17:37, Andy Goryachev wrote:
>
>     Have you tried building in Eclipse on the latest Linux Mint?  Or
>     building on an EncFS mount?
>
>     I don't know why Mint decided to use EncFS knowing its issues, and
>     I suppose I can try fixing my setup (it's a default Mint
>     installation), but I was quite surprised myself and thought that
>     it might be just as easy to fix the tests... here is how the fix
>     might look:
>
>     https://github.com/andy-goryachev-oracle/jfx/pull/9
>     <https://urldefense.com/v3/__https:/github.com/andy-goryachev-oracle/jfx/pull/9__;!!ACWV5N9M2RV99hQ!LaBncRdN0CNaCaX9i-HN9Ahy_JisIzv8qRh2QTWilcD8X42VuKB6KAjQhVsUxYY9XfQoGwBjmYhOucrVx_tv1PGChmrX$>
>
>     -andy
>
>     *From: *John Hendrikx <john.hendrikx at gmail.com>
>     <mailto:john.hendrikx at gmail.com>
>     *Date: *Tuesday, July 9, 2024 at 08:22
>     *To: *Andy Goryachev <andy.goryachev at oracle.com>
>     <mailto:andy.goryachev at oracle.com>, Johan Vos
>     <johan.vos at gluonhq.com> <mailto:johan.vos at gluonhq.com>,
>     openjfx-dev <openjfx-dev at openjdk.org> <mailto:openjfx-dev at openjdk.org>
>     *Subject: *[External] : Re: consistent naming for tests
>
>     On 09/07/2024 16:52, Andy Goryachev wrote:
>
>         Two test files consistently generate an error in Eclipse
>
>         - ObservableValueFluentBindingsTest
>         - LazyObjectBindingTest
>
>         I admit I have a weird setup (EncFS on Linux Mint running on
>         MacBook Pro), and it only manifests itself in Eclipse and not
>         in the gradle build - perhaps Eclipse actually verifies the
>         removal of files?
>
>         Anyway, a suggestion - if you use @Nested, please keep the
>         class names /short/.
>
>     This is not an Eclipse bug as I never encounter such issues.  143
>     characters is rather short these days, but I suppose we could
>     limit the nesting a bit.  Still, I'd look into a way to alleviate
>     this problem in your setup, sooner or later this is going to be a
>     problem.
>
>     --John
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/openjfx-dev/attachments/20240709/97f3fd41/attachment.htm>