RFR: 8323706: Remove SimpleSelector and CompoundSelector classes [v4]

Kevin Rushforth kcr at openjdk.org
Tue Jul 9 18:18:22 UTC 2024


On Tue, 9 Jul 2024 18:06:55 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> I can see if I can externalize this or if that would run into issues.  Also please note, although technically an API change, it is NOT an accessible API (and so can be removed at any time) because only the permitted types can access this API.
>> 
>> In other words, this could wait and be done separately or never.
>
> moving it to an internal class would eliminate the public API.
> 
> I agree with you that the risk is rather low because because the probability of people ever touching these classes is nearly zero.

I am fine with either approach. If it is easy, you can move it now, but there are no compatibility concerns with doing it later since a protected method of a sealed class without any exported subclasses is not accessible.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1333#discussion_r1670971671


More information about the openjfx-dev mailing list