RFR: 8331603: Cleanup native AbstractSurface methods getRGBImpl, setRGBImpl [v2]

Ambarish Rapte arapte at openjdk.org
Tue Jul 9 18:24:20 UTC 2024


On Tue, 9 Jul 2024 17:10:07 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   const vars
>
> modules/javafx.graphics/src/main/native-prism-sw/JAbstractSurface.c line 70:
> 
>> 68:         jint x, jint y, jint width, jint height) {
>> 69:     const jint dstX = 0;
>> 70:     const jint dstY = 0;
> 
> if it were up to me, I'd remove these as part of this PR.

Thank you Andy, We shall revisit this later under another issue.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1497#discussion_r1670979183


More information about the openjfx-dev mailing list