RFR: 8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first tooltip that is shown before it is displayed [v11]
Kevin Rushforth
kcr at openjdk.org
Thu Jul 11 12:27:05 UTC 2024
On Thu, 11 Jul 2024 11:10:35 GMT, Marius Hanl <mhanl at openjdk.org> wrote:
>> This PR fixes a long standing issue where the `Tooltip` will always wait one second until it appears the very first time, even if the
>> `-fx-show-delay` was set to another value.
>>
>> The culprit is, that the `cssForced` flag is not inside `Tooltip`, but inside the `TooltipBehaviour`. So the very first `Tooltip` gets processed correctly, but after no `Tooltip` will be processed by CSS before showing, resulting in the set `-fx-show-delay` to not be applied immediately.
>>
>> Added a bunch of headful and headless tests for the behaviour since there were none before.
>
> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
>
> Improve test code and change delta to 100
I looked at the code, and you're right, it doesn't seem like it would have mattered. Regardless, it now passes on my system reliably. I also reverted your fix and verified that the new test catches the failures. So all good from my point of view.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1394#issuecomment-2222793814
More information about the openjfx-dev
mailing list