RFR: 8336097: UserAgent Styles using lookups are promoted to Author level if look-up is defined in Author stylesheet
John Hendrikx
jhendrikx at openjdk.org
Fri Jul 12 10:36:24 UTC 2024
This change removes the origin determination from `resolveLookups`. Instead, the origin from the style is used.
Although a comment in the code alluded that this may cause problem with `INLINE` styles, this is not the case. Whenever a `Node` is associated with a `CssStyleHelper`, a suitable shared cache is determined for its use. This already takes into account the presence of an inline style, and only nodes with the same inline style can share such a cache. See `Cache#getStyleMap` and specifically this fragment where an additional selector is added for the inline style:
if (hasInlineStyle) {
Selector selector = cacheContainer.getInlineStyleSelector(inlineStyle);
if (selector != null) selectors.add(selector);
}
-------------
Commit messages:
- Remove origin determination from resolveLookups
Changes: https://git.openjdk.org/jfx/pull/1503/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1503&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8336097
Stats: 22 lines in 1 file changed: 0 ins; 16 del; 6 mod
Patch: https://git.openjdk.org/jfx/pull/1503.diff
Fetch: git fetch https://git.openjdk.org/jfx.git pull/1503/head:pull/1503
PR: https://git.openjdk.org/jfx/pull/1503
More information about the openjfx-dev
mailing list