RFR: 8336389: Infinite loop occurs while resolving lookups [v2]

Andy Goryachev angorya at openjdk.org
Tue Jul 16 18:09:58 UTC 2024


On Tue, 16 Jul 2024 17:47:11 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix formatting and spelling
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java line 43:
> 
>> 41: import static org.junit.Assert.assertFalse;
>> 42: import static org.junit.Assert.assertTrue;
>> 43: import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
> 
> We have a general "best practice" to not mix JUnit 4 and JUnit 5 calls in the same test class.

how did I miss that???

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1505#discussion_r1679838717


More information about the openjfx-dev mailing list