RFR: 8336389: Infinite loop occurs while resolving lookups [v2]

John Hendrikx jhendrikx at openjdk.org
Tue Jul 16 19:35:04 UTC 2024


On Tue, 16 Jul 2024 17:49:26 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix formatting and spelling
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java line 686:
> 
>> 684:         root.getChildren().addAll(a);
>> 685: 
>> 686:         assertDoesNotThrow(() -> stage.show());  // This should not result in a StackOverflowError
> 
> Since this is still a JUnit 4 test, perhaps replace this with a try/catch and call `Assert.fail` in the `catch` block?

Yeah, I can change that, I was hoping this (less important) PR would probably be integrated after #1503

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1505#discussion_r1679970140


More information about the openjfx-dev mailing list