RFR: 8336389: Infinite loop occurs while resolving lookups [v2]

[Andy Goryachev]

On Tue, 16 Jul 2024 19:35:46 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

> Are you on the latest Eclipse?

yes, 2024-06 (4.32.0)
they recently fixed a bug with collections in the Variables view...

>> modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java line 691:
>> 
>>> 689:     @Test
>>> 690:     public void shouldDetectNestedInfiniteLoop() throws IOException {
>>> 691:         Stylesheet stylesheet = new CssParser().parse(
>> 
>> `CssParser.parse(String,String)` is used only in tests, why are we using it?  Shouldn't we use `CssParser.parse(String)` instead?
>> 
>> Also, why do we need `CssParser.parse(String,String)` in the first place?
>
> I can change it; I just followed what was done in this file already.

that's fine; it might be a case of the dead code being left from some earlier iteration.

it's a public API not used by the platform, it seems.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1505#issuecomment-2231698678
PR Review Comment: https://git.openjdk.org/jfx/pull/1505#discussion_r1679977068