RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v18]

[Ambarish Rapte]

On Tue, 9 Jul 2024 14:48:30 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> I manually reverted the add/remove part, and replaced it with `git mv`. I assume/hope that by squashing the commits, the add/remove will not be part of the change.
>
> git doesn't actually track renames and copies, so there is ultimately no difference between a "git mv" and "git rm; git add", at least not when done as part of a single commit. What git does is a heuristic when presenting diffs based on how similar the two files are.

My intention to use git mv was to retain history on the file. I tried below locally but it did not retain the history.

git mv <orig-path> <new-path>
< modify the file content >
git add <new-path>
git commit -m "commit message"
git log --follow <new-path>  -> expected to see old commits in log but it showed only one log.

What am I missing here !

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1283#discussion_r1681953047