RFR: 8336798: DRT test cssrounding.html test for linear layout fails with WebKit 619.1 [v5]

Hima Bindu Meda hmeda at openjdk.org
Mon Jul 22 05:27:40 UTC 2024


On Sun, 21 Jul 2024 07:03:11 GMT, Jay Bhaskar <jbhaskar at openjdk.org> wrote:

>> Issue: CSSRounding.html DRT Test fails due sub pixel layout. The fractional value adds up to 1px extra height.
>> Solution: The Prefer height calculation should do flooring of fractional values. This is valid for Linear Layout which is a legacy support to most of the browsers.
>
> Jay Bhaskar has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
> 
>  - Merge remote-tracking branch 'upstream/master' into 8336798
>  - make test as JNUIT5 and apply review comments
>  - restore master file
>  - remove extra files checked in by mistake
>  - 8336798: DRT test cssrounding.html test for linear layout fails with WebKit 619.1
>  - 8335548: testCookieEnabled fails with WebKit 619.1

Verified that the test is now successful. Changes look fine

-------------

Marked as reviewed by hmeda (Committer).

PR Review: https://git.openjdk.org/jfx/pull/1514#pullrequestreview-2190650467


More information about the openjfx-dev mailing list