RFR: 8336097: UserAgent Styles using lookups are promoted to Author level if look-up is defined in Author stylesheet [v2]

John Hendrikx jhendrikx at openjdk.org
Mon Jul 22 14:13:38 UTC 2024


On Fri, 19 Jul 2024 22:49:02 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add test case
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java line 696:
> 
>> 694:         AUTHOR_OVERRIDES_USER_AGENT(RED_STYLESHEET, null, GRAY_STYLESHEET, null),
>> 695:         AUTHOR_OVERRIDES_INDIRECT_USER_AGENT(RED_INDIRECT_STYLESHEET, null, GRAY_STYLESHEET, null),
>> 696:         AUTHOR_OVERRIDES_PROPERTY(RED_STYLESHEET, Color.BLUE, GRAY_STYLESHEET, null),
> 
> should another one be added here:
> `AUTHOR_OVERRIDES_PROPERTY2(RED_INDIRECT_STYLESHEET, Color.BLUE, GRAY_STYLESHEET, null),`
> 
> and also
> `AUTHOR_OVERRIDES_PROPERTY(RED_INDIRECT_STYLESHEET, Color.BLUE, GRAY_STYLESHEET, "-fx-base: yellow"),`

I've added the indirect cases in a separate blocks.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1503#discussion_r1686623573


More information about the openjfx-dev mailing list