RFR: 8336389: Infinite loop occurs while resolving lookups [v2]

[John Hendrikx]

On Mon, 22 Jul 2024 15:17:43 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> You might want to merge in the latest upstream master to pick up the JUnit 5 change (also, Skara doesn't report a conflict, but GitHub does).
>
>> You might want to merge in the latest upstream master to pick up the JUnit 5 change (also, Skara doesn't report a conflict, but GitHub does).
> 
> Skara woke up and reported the merge conflict, so you will need to merge master anyway.

@kevinrushforth 

> I'll approve it as-is and reapprove if you are able to add a check for `CssParser::errorsProperty`.

So, I added a check there, but must say the error system seems a bit unfinished/unpolished... this took way longer than it should have for the following reasons:

- The `errorsProperty` will simply **not** be filled at all if you didn't access it first at least once.  This is undocumented.
- The strings produced uses a mix of line-endings on Windows (sometimes `\r\n`, sometimes `\n`), which isn't at all apparent when logging them to the console and trying to match them
- The produced strings are hard to read; it's some kind of text/xml/json hybrid
- Value is sometimes `value` sometimes `Value`
- The word `value` seems a bit overused, a part of the output:


<Value>
  <value values="2">
    <Value>
      <value>50.0%</value>


- Sometimes the produced string contains "indents" that are not preceded by a newline...


</Value>    <Value>

- Indents use a mix of tabs and spaces

In the PR you can see the strings it produces...

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1505#issuecomment-2243762206