RFR: 8336097: UserAgent Styles using lookups are promoted to Author level if look-up is defined in Author stylesheet [v5]
Jahin9999
duke at openjdk.org
Mon Jul 22 23:37:38 UTC 2024
On Mon, 22 Jul 2024 16:01:12 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:
>> This change removes the origin determination from `resolveLookups`. Instead, the origin from the style is used.
>>
>> Although a comment in the code alluded that this may cause problem with `INLINE` styles, this is not the case. Whenever a `Node` is associated with a `CssStyleHelper`, a suitable shared cache is determined for its use. This already takes into account the presence of an inline style, and only nodes with the same inline style can share such a cache. See `Cache#getStyleMap` and specifically this fragment where an additional selector is added for the inline style:
>>
>> if (hasInlineStyle) {
>> Selector selector = cacheContainer.getInlineStyleSelector(inlineStyle);
>> if (selector != null) selectors.add(selector);
>> }
>
> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>
> Fixed comments
Marked as reviewed by Jahin9999 at github.com (no known OpenJDK username).
-------------
PR Review: https://git.openjdk.org/jfx/pull/1503#pullrequestreview-2192705859
More information about the openjfx-dev
mailing list