RFR: 8336331: Doc: Clarification in AccessibleAttribute, AccessibleRole [v2]

Ambarish Rapte arapte at openjdk.org
Wed Jul 24 08:46:38 UTC 2024


On Tue, 23 Jul 2024 14:45:19 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/javafx/scene/AccessibleRole.java line 486:
>> 
>>> 484:      * <li> {@link AccessibleAction#SET_TEXT} </li>
>>> 485:      * <li> {@link AccessibleAction#SET_TEXT_SELECTION} </li>
>>> 486:      * <li> {@link AccessibleAction#SHOW_TEXT_RANGE} </li>
>> 
>> As per the documentation of `AccessibleAction.SHOW_TEXT_RANGE`, it used by both TextField and TextArea.
>> Given that, we should add this action for TEXT_FILED role also.
>
> Thanks for catching this!
> 
> Only TextArea has a meaningful implementation, all other descendants of TextInputControl have a no-op (see `scrollCharacterToVisible()`, TextInputControlSkin:736)
> 
> We need to remove TextField mention from `AccessibleAction.SHOW_TEXT_RANGE`.

TextField can be scrolled horizontally, so seems like even TextField should respond to SHOW_TEXT_RANGE.
So, instead of removing TextField mention from AccessibleAction.SHOW_TEXT_RANGE, a bug can/should be filed for missing implementation.
What do you think ?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1512#discussion_r1689385798


More information about the openjfx-dev mailing list