RFR: 8336331: Doc: Clarification in AccessibleAttribute, AccessibleRole [v2]
Ambarish Rapte
arapte at openjdk.org
Wed Jul 24 08:57:38 UTC 2024
On Tue, 23 Jul 2024 14:52:02 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/AccessibleAttribute.java line 694:
>>
>>> 692: /**
>>> 693: * Returns the text selection start offset for the node.
>>> 694: * Selection start corresponds to the smaller offset in the selection range.
>>
>> Just an observation, The selection is represented by IndexRange where we refer the start and end as **index**. But here in this file, we refer them as offset.
>
> Hmm, actually, `IndexRange.getStart()` L76 and `.getEnd()` L84 refer to start/end _position_.
I was just sharing an observation, wasn't expecting any change.
In this file, documentation already refer them as offset at a few places, like BOUNDS_FOR_RANGE, LINE_START, LINE_END.
So, offset seems more suitable in this file.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1512#discussion_r1689401982
More information about the openjfx-dev
mailing list