RFR: 8334874: Horizontal scroll events from touch pads should scroll the TabPane tabs [v4]

Kevin Rushforth kcr at openjdk.org
Thu Jul 25 15:53:41 UTC 2024


On Wed, 24 Jul 2024 23:12:05 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

>> This PR considers the horizontal scroll events that can be generated on a trackpad, on an horizontally sided `TabPane` control (top or bottom), adding to the existing vertical scroll events from mouse wheel and trackpad, to scroll its tabs.
>> 
>> Therefore, scrolling a `TabPane` will behave in the same way that `ScrollBar` does regarding those same events and control orientation (vertical/horizontal).
>
> Jose Pereda has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove extra new line

LGTM

I ran the program attached to the bug report and it now recognizes horizontal scroll as expected. I also verified that the newly added test fails without your fix and passes with your fix.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1486#pullrequestreview-2199713527


More information about the openjfx-dev mailing list