RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v5]

Thiago Milczarek Sayao tsayao at openjdk.org
Mon Jul 29 14:29:17 UTC 2024


> This fixes two bugs appointed on the JBS issue:
> 
> 1) Sometimes window was moving to the top left corner - seems to be a bug somewhere in `gdk_window_get_origin` when used before map (a X concept when the window appears). The change is to ignore the configure events (happens when location or size changes) until window is mapped. Before map java is notified in the `set_bounds` function.
> 
> This seems to happen on newer versions of linux distros.
> 
> 2) Specific to KDE, in the case of the example provided, when an MODAL window pops, it calls `set_enabled` `false` on the child (or all other windows if APPLICATION_MODAL) which causes it to update the window constraints. When maximized, the constraints where applied anyways, causing the window to still be maximized but not show as maximized. The change is to not apply constraints when not floating (meaning floating on the screen - not maximized, fullscreen or iconified).

Thiago Milczarek Sayao has updated the pull request incrementally with two additional commits since the last revision:

 - Revert idea file
 - Fix only the original bug

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1460/files
  - new: https://git.openjdk.org/jfx/pull/1460/files/7f0115d0..b90968c0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1460&range=04
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1460&range=03-04

  Stats: 14 lines in 3 files changed: 0 ins; 13 del; 1 mod
  Patch: https://git.openjdk.org/jfx/pull/1460.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1460/head:pull/1460

PR: https://git.openjdk.org/jfx/pull/1460


More information about the openjfx-dev mailing list