RFR: 8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first tooltip that is shown before it is displayed [v6]

Marius Hanl mhanl at openjdk.org
Tue Jun 4 12:39:23 UTC 2024


On Tue, 28 May 2024 16:48:39 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add a test for changing the stylesheet and always process CSS for that matter
>
> tests/system/src/test/java/test/robot/javafx/scene/TooltipTest.java line 134:
> 
>> 132: 
>> 133:     @Test
>> 134:     void testSmallShowDelayTooltip() {
> 
> what is the reason for removing 'public' keyword?

JUnit 5 does not require you to keep the methods public.
It was mostly done for better encapsulation, you can read more here, where also one of the JUnit Team responded. :)
https://stackoverflow.com/questions/55215949/why-junit-5-default-access-modifier-changed-to-package-private

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1394#discussion_r1625927230


More information about the openjfx-dev mailing list