RFR: 8330304: MenuBar: Invisible Menu works incorrectly with keyboard arrows [v2]

[Kevin Rushforth]

On Fri, 31 May 2024 15:17:19 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> The root cause is that the skin used two fields to store one entity (`focusedMenu` and `focusedMenuIndex`), causing mismatch when invisible menu(s) are present.
>> 
>> The fix involves using a single index variable.
>> 
>> Also wanted to note that in theory, `openMenu` and `openMenuButton` can also be replaced with a single boolean, but I decided not to change these in order to keep the amount of diffs to a minimum.
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comments

The fix looks good. I also verified that it fixes the problem, and that the new test passes with the fix and fails without the fix.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1467#pullrequestreview-2099793415