RFR: 8311895: CSS Transitions [v22]

[Kevin Rushforth]

On Fri, 31 May 2024 15:09:38 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> Implementation of [CSS Transitions](https://www.w3.org/TR/css-transitions-1/).
>> 
>> ### Future enhancements
>> CSS transition support for backgrounds and borders: #1471 
>> 
>> ### Limitations
>> This implementation supports both shorthand and longhand notations for the `transition` property. However, due to limitations of JavaFX CSS, mixing both notations doesn't work:
>> 
>> .button {
>>     transition: -fx-background-color 1s;
>>     transition-easing-function: linear;
>> }
>> 
>> This issue should be addressed in a follow-up enhancement.
>
> Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 62 commits:
> 
>  - Merge branch 'refs/heads/master' into feature/css-transitions
>  - document css parser limitation
>  - documentation change
>  - added documentation
>  - address review comments
>  - Merge branch 'refs/heads/master' into feature/css-transitions
>  - extract magic string to named constant
>  - use existing property in test
>  - fixed documentation
>  - Merge branch 'master' into feature/css-transitions
>  - ... and 52 more: https://git.openjdk.org/jfx/compare/cf09d6f1...10c06a97

The docs look good. I left one comment on the doc images and one question on the cssref.html changes. In parallel, I'll look at the CSR.

modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line 704:

> 702:         <tr>
> 703:         <th class="propertyname" scope="row">transition‑property</th>
> 704:           <td class="value">[ none | all | <custom‑ident># ]</td>

Why is there a literal `#` after `<custom‑ident>` (and others below)? It shows up when viewing the doc.

-------------

PR Review: https://git.openjdk.org/jfx/pull/870#pullrequestreview-2097400072
PR Review Comment: https://git.openjdk.org/jfx/pull/870#discussion_r1628176431