RFR: 8277848: Binding and Unbinding to List leads to memory leak [v10]

[Kevin Rushforth]

On Wed, 5 Jun 2024 07:29:58 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:

>> Florian Kirmaier has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
>> 
>>  - Merge branch 'openjdk:master' into JDK-8277848-list-binding-leak
>>  - JDK-8277848
>>    Removed print statements
>>  - Merge remote-tracking branch 'origjfx/master' into JDK-8277848-list-binding-leak
>>    
>>    # Conflicts:
>>    #	modules/javafx.base/src/main/java/javafx/beans/property/ListPropertyBase.java
>>    #	modules/javafx.base/src/main/java/javafx/beans/property/SetPropertyBase.java
>>    #	modules/javafx.base/src/test/java/test/javafx/beans/property/SetPropertyBaseTest.java
>>  - Merge remote-tracking branch 'origjfx/master' into JDK-8277848-list-binding-leak
>>  - JDK-8277848
>>    Added tests to ensure no premature garbage collection is happening.
>>  - JDK-8277848
>>    Added 3 more tests to verify that a bug discussed in the PR does not appear.
>>  - JDK-8277848
>>    Added the 3 requests whitespaces
>>  - JDK-8277848
>>    Further optimization based code review.
>>    This Bugfix should now event improve the performance
>>  - JDK-8277848
>>    Added missing change
>>  - JDK-8277848
>>    Fixed memoryleak, when binding and unbinding a ListProperty. The same was fixed for SetProperty and MapProperty.
>
> Reopened, rebased with master,
> I still think this fixes a big problem.

@FlorianKirmaier You haven't answered @hjohn 's valid concerns. Until you do, I don't see the current version of this PR going anywhere.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/689#issuecomment-2150908626