Integrated: 8330304: MenuBar: Invisible Menu works incorrectly with keyboard arrows
Andy Goryachev
angorya at openjdk.org
Thu Jun 6 14:46:53 UTC 2024
On Thu, 30 May 2024 15:36:37 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
> The root cause is that the skin used two fields to store one entity (`focusedMenu` and `focusedMenuIndex`), causing mismatch when invisible menu(s) are present.
>
> The fix involves using a single index variable.
>
> Also wanted to note that in theory, `openMenu` and `openMenuButton` can also be replaced with a single boolean, but I decided not to change these in order to keep the amount of diffs to a minimum.
This pull request has now been integrated.
Changeset: 4a33d5ef
Author: Andy Goryachev <angorya at openjdk.org>
URL: https://git.openjdk.org/jfx/commit/4a33d5ef13c7bc72900fa6769fe4779ccec5bc98
Stats: 84 lines in 3 files changed: 68 ins; 9 del; 7 mod
8330304: MenuBar: Invisible Menu works incorrectly with keyboard arrows
Reviewed-by: mstrauss, kcr
-------------
PR: https://git.openjdk.org/jfx/pull/1467
More information about the openjfx-dev
mailing list