RFR: 8330559: Trailing space not rendering correctly in TextFlow in RTL mode [v2]

[Andy Goryachev]

On Thu, 6 Jun 2024 15:21:15 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/com/sun/javafx/font/coretext/CTGlyphLayout.java line 161:
>> 
>>> 159:              * When traling spces are present in the text containing LTR and RTL
>>> 160:              * text together, negative position values are returned for spaces from
>>> 161:              * the native side. Since TextRun expects positive value relative to the
>> 
>> should we limit the scope of the change to mac only (PlatformUtil.isMac()?) since CTGlyphLayout is common code?
>
> CTGlyphLayout is not common code. It is mac only (so no need to mention mac)

I see, PrismFontFactory:164 getNativeFactoryName().
It would be nice to place platform-specific code in a package bearing the platform name, or at least mention this in a class-level comment, but I guess it's too late.

It means the scope is already limited to macOS, we are good.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1468#discussion_r1629765619