[External] : Re: Eclipse and Gradle in OpenJFX

[Andy Goryachev]

Thank you Kevin, for this bit of insight.  I see the Buildship issue mentioned in one of the comments is still open with no one assigned

https://github.com/eclipse/buildship/issues/658

Chances that it will be fixed in a reasonable time frame are slim to none.  I would recommend to make the changes (remove the gradle nature from eclipse config files) in the meantime, as it allows for clean import of the whole thing into Eclipse.

Once the situation with Buildship changes, we can remove the Eclipse files altogether and rely on gradle import per JDK-8223374.

I am also very interested in Nir's view on the subject.

-andy



From: Kevin Rushforth <kevin.rushforth at oracle.com>
Date: Tuesday, June 18, 2024 at 16:09
To: Andy Goryachev <andy.goryachev at oracle.com>, Thiago Milczarek Sayão <thiago.sayao at gmail.com>
Cc: openjfx-dev at openjdk.org <openjfx-dev at openjdk.org>
Subject: Re: [External] : Re: Eclipse and Gradle in OpenJFX
We also did that for NetBeans, meaning we removed the NetBeans IDE-specific files and use their gradle plug-in (with somewhat mixed results). See https://bugs.openjdk.org/browse/JDK-8223375

FWIW, there is an open issue to do the same for Eclipse, but I think it hasn't been looked at in a while. Nir is the assignee so he will likely have some thoughts on this. https://bugs.openjdk.org/browse/JDK-8223374

-- Kevin

On 6/18/2024 1:14 PM, Andy Goryachev wrote:
Interesting, thank you, Thiago.

Maybe it's just the quality of gradle support in IntelliJ, or complexity of the Buildship plug-in in Eclipse.  It never worked for me, and removing the gradle nature from Eclipse project files has an added benefit of removing an extra dependency.

-andy



From: Thiago Milczarek Sayão <thiago.sayao at gmail.com><mailto:thiago.sayao at gmail.com>
Date: Tuesday, June 18, 2024 at 12:51
To: Andy Goryachev <andy.goryachev at oracle.com><mailto:andy.goryachev at oracle.com>
Cc: openjfx-dev at openjdk.org<mailto:openjfx-dev at openjdk.org> <openjfx-dev at openjdk.org><mailto:openjfx-dev at openjdk.org>
Subject: [External] : Re: Eclipse and Gradle in OpenJFX
Andy,

We kind of did the opposite for Intellij (got rid of the .iml files and went for gradle import):

https://github.com/openjdk/jfx/pull/1009<https://urldefense.com/v3/__https:/github.com/openjdk/jfx/pull/1009__;!!ACWV5N9M2RV99hQ!KGyKiKF64SpFYCZE7vMq0nzFAyNGv-gTQJoxy9lGH2dg15mO5dl-ZuQha_yGdjFGH_l740roARzs-f231vB1WSlkRk4$>

I couldn't get it to detect the manual tests tho. Changing some gradle files worked, but would require a deeper review, so we went without it.

-- Thiago.

Em ter., 18 de jun. de 2024 às 16:05, Andy Goryachev <andy.goryachev at oracle.com<mailto:andy.goryachev at oracle.com>> escreveu:
Dear developers:

Does anyone use gradle in Eclipse (Buildship plug-in) with the OpenJFX repo?

The reason I am asking is that in my experience, the gradle nature in OpenJFX is either misconfigured, or obsolete, or both.  There is a rather old wiki page [0] which describes the Eclipse setup, though I don't think it is correct anymore.  The initial import of the repository in Eclipse triggers an internal gradle run which creates/modifies a bunch of .classpath and .project files which must be undone before the workspace becomes usable.  In any case, only a proper command line gradle build is supported anyway.

I would like to propose removing the gradle nature from Eclipse's .project files in OpenJFX.  Once done, the projects can be trivially imported into a new workspace with no extra steps required.  This change has no impact on command line build whatsoever.

What do you think?

Thank you
-andy



References

[1] https://wiki.openjdk.org/display/OpenJFX/Using+an+IDE#UsinganIDE-ConfigureEclipsetousethelatestJDK

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/openjfx-dev/attachments/20240618/e8ffa6ad/attachment-0001.htm>