RFR: 8088923: IOOBE when adding duplicate categories to the BarChart [v2]

[Markus Mack]

On Thu, 20 Jun 2024 16:52:49 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> However, I don't see the issue if I just add a duplicate data point after the chart is rendered (the code jumps to line 218 (edit: 216, sorry) in the master branch).
>> 
>> This makes me think that perhaps the fix should include fixing the logic of adding category to the right hashtables at the right moment.  What do you think?
>
> I've added a popup menu on the BarChart page in the Monkey Tester to test the case ...
> https://github.com/andy-goryachev-oracle/MonkeyTest

You'll need to add an additional point after adding the one with duplicate categories to see the exception in the console. Using the "Add Point" button in the monkey tester after using the context menu entry should reproduce the issue.
Regarding category hashtables, do you have any specific issues in mind, or see any regressions due to this PR? Otherwise I'd suggest to create separate issues / failing tests and do follow-up PRs.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1476#discussion_r1647940331