RFR: 8088923: IOOBE when adding duplicate categories to the BarChart [v2]

[Markus Mack]

On Thu, 20 Jun 2024 17:44:41 GMT, Markus Mack <mmack at openjdk.org> wrote:

>> This PR provides the test case given in the JBS issue, and a simple fix for the index calculation when inserting data after previous data with duplicate categories.
>> 
>> Also, I've added a comment to `BarChart`s javadoc, clarifying the behavior that was apparently assumed (but broken) previously.
>> 
>> The index lookup is skipped for performance reasons if there are no duplicates, corresponding to the previous implementation.
>> Further optimizations would be possible, but probably are not really helpful without more extensive changes. The previous code already loops over all categories to check if they are present, typically nested in a loop adding many data items, thus already scaling quadratically when adding lots of mostly unique data points.
>
> Markus Mack has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JavaDoc formatting

Thanks, I can reproduce this now, both in master and this PR, so it may even be another unrelated issue. I can have a look if it actually touches this PR or not.

The legends being added in your screenshot are correct, that's actually what the monkey tester method is currently doing (adding empty series, because the code just modifies the first series). However, the tick marks on the axis are in incorrect places (which I'm pretty sure is the next unrelated bug...)

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1476#issuecomment-2181359648