RFR: 8331765: Websocket callbacks are not executed after WebKit 617.1 update [v4]

Hima Bindu Meda hmeda at openjdk.org
Fri Jun 21 12:36:18 UTC 2024


On Fri, 21 Jun 2024 00:07:33 GMT, Jay Bhaskar <jbhaskar at openjdk.org> wrote:

>> Issue: The Websocket Channel is broken 
>> Solution: The socket Provider needs a web page pointer, since the web socket channel source code is moved to WebkitLegacy in 617.1 for the web process model, it is invalid for JavaFx Webkit.
>
> Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix typos meesage to message

Changes look fine

tests/manual/web/WebSocketTestApp.java line 70:

> 68:         loadButton.setOnAction(e -> {
> 69:             URL url = this.getClass().getResource("websocket.html");
> 70:             System.out.println(url);

Minor:Is it required to print url in the terminal?

-------------

Marked as reviewed by hmeda (Committer).

PR Review: https://git.openjdk.org/jfx/pull/1477#pullrequestreview-2132540876
PR Review Comment: https://git.openjdk.org/jfx/pull/1477#discussion_r1648894257


More information about the openjfx-dev mailing list