RFR: 8327255: javac lint warnings: removal, missing-explicit-ctor [v2]

Kevin Rushforth kcr at openjdk.org
Sat Jun 22 13:37:30 UTC 2024


On Tue, 18 Jun 2024 14:16:25 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Kevin Rushforth has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'upstream/master' into 8327255-lint-removal,missing-explicit-ctor
>>  - fix typo and add missing tool tasks
>>  - 8334138: Suppress removal warnings for sun.misc.Unsafe memory access methods
>>  - 8334143: Suppress remaining removal warnings for internal methods and classes
>>  - 8327255: javac lint warnings: removal, missing-explicit-ctor
>
> build.gradle line 4139:
> 
>> 4137:             }
>> 4138:         } else if (compile.name == "compileJslcJava" ||
>> 4139:             compile.name == "compileToolJava") {
> 
> Should we include the _compileToolsJava_ task from media too ?

That was a typo: "compileToolJava" should have been "compileToolsJava". While checking this, I also found that I missed two other tools tasks, "compileDecoraCompilers" and "compilePrismCompilers", so I added them as well.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1474#discussion_r1649699902


More information about the openjfx-dev mailing list