RFR: 8314754: Minor ticks are not getting updated both the axes in LineChart

Andy Goryachev angorya at openjdk.org
Tue Jun 25 20:25:25 UTC 2024


On Tue, 25 Jun 2024 15:14:14 GMT, Markus Mack <mmack at openjdk.org> wrote:

> This PR ensures the `tickMarksUpdated()` method (overriden with minor tick mark layout code in subclasses) is called during `Chart` `Axis` layout when needed.
> Previously, it was only called when tick mark length or range was changed, which is not happening during axis animations, causing minor ticks to become outdated when animations are enabled.
> 
> I've added a test that fails with the previous code, specifically checking the tick mark spacing.
> Alternatively the test could be implemented by accessing ValueAxis.minorTickMarkValues, which would need to be made at least package-private however (with a shim). This implementation checks the tick mark `Path` shape instead, which is already publicly accessible (but could be considered an implementation detail).

testing looks good.  also tried AreaChart, BubbleChart, ScatterChart, StackedAreaChart.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1489#issuecomment-2189903435


More information about the openjfx-dev mailing list