RFR: 8314754: Minor ticks are not getting updated both the axes in LineChart [v2]

Markus Mack mmack at openjdk.org
Tue Jun 25 21:46:25 UTC 2024


> This PR ensures the `tickMarksUpdated()` method (overriden with minor tick mark layout code in subclasses) is called during `Chart` `Axis` layout when needed.
> Previously, it was only called when tick mark length or range was changed, which is not happening during axis animations, causing minor ticks to become outdated when animations are enabled.
> 
> I've added a test that fails with the previous code, specifically checking the tick mark spacing.
> Alternatively the test could be implemented by accessing ValueAxis.minorTickMarkValues, which would need to be made at least package-private however (with a shim). This implementation checks the tick mark `Path` shape instead, which is already publicly accessible (but could be considered an implementation detail).

Markus Mack has updated the pull request incrementally with two additional commits since the last revision:

 - cleanup imports
 - add clarifying comment to test

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1489/files
  - new: https://git.openjdk.org/jfx/pull/1489/files/93ef4e69..1a853794

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1489&range=01
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1489&range=00-01

  Stats: 3 lines in 1 file changed: 1 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/jfx/pull/1489.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1489/head:pull/1489

PR: https://git.openjdk.org/jfx/pull/1489


More information about the openjfx-dev mailing list