RFR: 8314754: Minor ticks are not getting updated both the axes in LineChart [v3]

Marius Hanl mhanl at openjdk.org
Wed Jun 26 07:05:19 UTC 2024


On Wed, 26 Jun 2024 06:33:43 GMT, Markus Mack <mmack at openjdk.org> wrote:

>> This PR ensures the `tickMarksUpdated()` method (overriden with minor tick mark layout code in subclasses) is called during `Chart` `Axis` layout when needed.
>> Previously, it was only called when tick mark length or range was changed, which is not happening during axis animations, causing minor ticks to become outdated when animations are enabled.
>> 
>> I've added a test that fails with the previous code, specifically checking the tick mark spacing.
>> Alternatively the test could be implemented by accessing ValueAxis.minorTickMarkValues, which would need to be made at least package-private however (with a shim). This implementation checks the tick mark `Path` shape instead, which is already publicly accessible (but could be considered an implementation detail).
>
> Markus Mack has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use JUnit4 assertEquals

Marked as reviewed by mhanl (Committer).

-------------

PR Review: https://git.openjdk.org/jfx/pull/1489#pullrequestreview-2140899917


More information about the openjfx-dev mailing list