Integrated: 8314754: Minor ticks are not getting updated both the axes in LineChart
Markus Mack
mmack at openjdk.org
Wed Jun 26 18:26:15 UTC 2024
On Tue, 25 Jun 2024 15:14:14 GMT, Markus Mack <mmack at openjdk.org> wrote:
> This PR ensures the `tickMarksUpdated()` method (overriden with minor tick mark layout code in subclasses) is called during `Chart` `Axis` layout when needed.
> Previously, it was only called when tick mark length or range was changed, which is not happening during axis animations, causing minor ticks to become outdated when animations are enabled.
>
> I've added a test that fails with the previous code, specifically checking the tick mark spacing.
> Alternatively the test could be implemented by accessing ValueAxis.minorTickMarkValues, which would need to be made at least package-private however (with a shim). This implementation checks the tick mark `Path` shape instead, which is already publicly accessible (but could be considered an implementation detail).
This pull request has now been integrated.
Changeset: b80b106d
Author: Markus Mack <mmack at openjdk.org>
Committer: Andy Goryachev <angorya at openjdk.org>
URL: https://git.openjdk.org/jfx/commit/b80b106df9eee12fc42d85cf9386975dc56c5a57
Stats: 41 lines in 2 files changed: 39 ins; 2 del; 0 mod
8314754: Minor ticks are not getting updated both the axes in LineChart
Reviewed-by: angorya, mhanl
-------------
PR: https://git.openjdk.org/jfx/pull/1489
More information about the openjfx-dev
mailing list