RFR: 8326619: Stage.sizeToScene() on maximized/fullscreen Stage breaks the Window [v8]
Kevin Rushforth
kcr at openjdk.org
Wed Jun 26 20:54:16 UTC 2024
On Tue, 25 Jun 2024 08:01:49 GMT, Marius Hanl <mhanl at openjdk.org> wrote:
>> This PR fixes the problem that maximizing/fullscreen a `Stage` or `Dialog` is broken when `sizeToScene()` was called before or after.
>>
>> The approach here is to ignore the `sizeToScene()` request when the `Stage` is maximized or set to fullscreen.
>> Otherwise the Window Manager of the OS will be confused and you will get weird flickering or wrong Window buttons (e.g. on Windows, the 'Maximize' button still shows the 'Restore' Icon, while we already resized the `Stage` to not be maximized).
>
> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
>
> Added sleep in tests / format javadoc
Looks good. I'll review the CSR and then you can "Finalize" it.
-------------
Marked as reviewed by kcr (Lead).
PR Review: https://git.openjdk.org/jfx/pull/1382#pullrequestreview-2142946665
More information about the openjfx-dev
mailing list