RFR: 8299753: Tree/TableView: Column Resizing With Fractional Scale

[Andy Goryachev]

On Fri, 30 Jun 2023 05:38:35 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> Modified the resize algorithm to work well with fractional scale, thanks for deeper understanding of the problem thanks to  @hjohn and @mstr2 .
>> 
>> Removed earlier manual tester in favor of the monkey tester.
>> 
>> It is important to note that even though the constraints are given by the user in unsnapped coordinates, they are converted to snapped values, since the snapped values correspond to the actual pixels on the display.  This means the tests that validate honoring constraints should, in all the cases where (scale != 1.0), assume possibly error not exceeding (1.0 / scale).
>
> Left a inline comment.
> Otherwise looks good to me

@karthikpandelu @hjohn @kevinrushforth could you please review?

> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/ResizeHelper.java line 112:
> 
>> 110:                 distribute(delta, pref);
>> 111:             }
>> 112:         } else if (delta > 0.0) {
> 
> Do we need delta = 0.0 condition here?

excellent question.  we don't - zero delta means no change, so no action is needed.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1156#issuecomment-1834391879
PR Review Comment: https://git.openjdk.org/jfx/pull/1156#discussion_r1248011392