RFR: 8326712: Robot tests fail on XWayland

[Johan Vos]

On Thu, 27 Jun 2024 18:26:20 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/native-glass/gtk/fp_pipewire.h line 26:
>> 
>>> 24:  */
>>> 25: 
>>> 26: #ifdef HEADLESS
>> 
>> There is no HEADLESS build for JavaFX.  I see the same ifdef in other C files in this PR.
>> I guess its harmless so I'll let Kevin decide what we should do
>
> I don't have a strong opinion. This file is unchanged relative to the original in AWT. The other three already have some changes, so I'd probably lean toward removing it.

With the headless platform that I started in the sandbox project, there is the concept of headless, but rather than compiling native code with `#ifdef HEADLESS` the current approach is to avoid those native compilations at all.
However, I don't exclude that some parts of a file might make sense for a headless glass platform, where other parts should not be considered. In that case, the `ifdef HEADLESS` and in general the compile option `-DHEADLESS` would make sense.
While this is not needed at this moment (and not even sure it will ever be needed), I am slightly in favor of keeping it here.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1490#discussion_r1658253705