RFR: 8325073: javadoc warnings: missing @param tags and other issues [v2]

Ambarish Rapte arapte at openjdk.org
Fri Mar 1 03:43:52 UTC 2024


On Fri, 1 Mar 2024 00:22:05 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> This change brings the number of javadoc warnings back to 91 (to be fixed in [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996))
>> 
>> - adds missing information in `@param` tags
>>  - adds `@SuppressWarnings("doclint:missing")` to `Skinnable` to silence the warning due to [JDK-8325071](https://bugs.openjdk.org/browse/JDK-8325071)
>>  - fixed an empty `<p>` in `Subscription`
>>  - cleaned up unnecessary `@throws` in Filtered/SortedList
>> 
>> This PR does not need a CSR: most of the changes are clarifications or documenting of missing parameters.
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comments

Looks good. Warnings reduced from 186 to 91.
One minor comment that at several instances there is no empty line between the description and `@param`. Shall re-approve if changed.

-------------

Marked as reviewed by arapte (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1384#pullrequestreview-1910264103


More information about the openjfx-dev mailing list