RFR: 8270996: javadoc: missing comments in serialized classes [v3]

Prasanta Sadhukhan psadhukhan at openjdk.org
Fri Mar 1 03:51:50 UTC 2024


On Thu, 29 Feb 2024 23:56:06 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Adding `@SuppressWarnings("doclint:missing")` to the lines in Serializable classes that generated javadoc's "missing comments" warning.
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comments

modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPanel.java line 142:

> 140:  * future Swing or JavaFX releases. The current serialization support is
> 141:  * appropriate for short term storage or RMI between applications running
> 142:  * the same version of Swing and the same version of JavaFX.

Shouldn;t we need to add
@SuppressWarnings("serial") // Same-version serialization only

which I see in almost all classes in Swing which has the above serialization warning...

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1386#discussion_r1508447661


More information about the openjfx-dev mailing list