RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v13]

Karthik P K kpk at openjdk.org
Mon Mar 4 11:07:57 UTC 2024


On Thu, 29 Feb 2024 17:33:14 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> @hjohn how do you get this coverage diagram?
>> 
>> The BreakIterator is a part of the existing code, we should probably have this discussion outside of this PR.  I agree, there might be a situation when the app wants to select a specific locale for the text component instead of relying on the default locale.
>
> @andy-goryachev-oracle  The coverage comes from EclEmma, an Eclipse plugin. Once installed, there is another way to run tests called `Coverage as...` just above `Run as...`.  It's very useful to use it on a JUnit test to see if there are major branches you missed in testing that may require additional cases.

Thank you @hjohn for providing the test. I have added this.
Since we do not use scene in this test, I think it is difficult to test HitInfo in RTL mode. However these tests will be very useful in testing the HitInfo.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1323#discussion_r1510982462


More information about the openjfx-dev mailing list