RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v17]
John Hendrikx
jhendrikx at openjdk.org
Mon Mar 4 17:22:58 UTC 2024
On Mon, 4 Mar 2024 11:01:09 GMT, Karthik P K <kpk at openjdk.org> wrote:
>> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation conditions were not considered, hence hit test values such as character index and insertion index values were incorrect.
>>
>> Added checks for RTL orientation of nodes and fixed the issue in `getHitInfo()` to calculate correct hit test values.
>>
>> Added system tests to validate the changes.
>
> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
>
> Add unit test
LGTM
-------------
Marked as reviewed by jhendrikx (Committer).
PR Review: https://git.openjdk.org/jfx/pull/1323#pullrequestreview-1914883510
More information about the openjfx-dev
mailing list