RFR: 8270996: javadoc: missing comments in serialized classes [v3]

[Prasanta Sadhukhan]

On Fri, 1 Mar 2024 17:11:00 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> FYI: after merging this and #1384 together all I see in the build log are 4 native warnings (on macOS):
>> 
>> 
>> /Users/angorya/Projects/jfx-1/jfx/rt/modules/javafx.graphics/src/main/native-prism-es2/macosx/MacOSXWindowSystemInterface.m:93:21: warning: 'lockFocusIfCanDraw' is deprecated: first deprecated in macOS 10.14 - To draw, subclass NSView and implement -drawRect:; AppKit's automatic deferred display mechanism will call -drawRect: as necessary to display the view. [-Wdeprecated-declarations]
>>         if ([nsView lockFocusIfCanDraw] == NO) {
>>                     ^
>> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSView.h:190:1: note: 'lockFocusIfCanDraw' has been explicitly marked deprecated here
>> - (BOOL)lockFocusIfCanDraw API_DEPRECATED("To draw, subclass NSView and implement -drawRect:; AppKit's automatic deferred display mechanism will call -drawRect: as necessary to display the view.", macos(10.0,10.14));
>> ^
>> /Users/angorya/Projects/jfx-1/jfx/rt/modules/javafx.graphics/src/main/native-prism-es2/macosx/MacOSXWindowSystemInterface.m:98:25: warning: 'unlockFocus' is deprecated: first deprecated in macOS 10.14 - To draw, subclass NSView and implement -drawRect:; AppKit's automatic deferred display mechanism will call -drawRect: as necessary to display the view. [-Wdeprecated-declarations]
>>                 [nsView unlockFocus];
>>                         ^
>> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSView.h:189:1: note: 'unlockFocus' has been explicitly marked deprecated here
>> - (void)unlockFocus API_DEPRECATED("To draw, subclass NSView and implement -drawRect:; AppKit's automatic deferred display mechanism will call -drawRect: as necessary to display the view.", macos(10.0,10.14));
>> ^
>> /Users/angorya/Projects/jfx-1/jfx/rt/modules/javafx.graphics/src/main/native-prism-es2/macosx/MacOSXWindowSystemInterface.m:120:24: warning: 'setView:' is deprecated: first deprecated in macOS 10.14 - Use NSOpenGLView to provide OpenGL content in a Cocoa app. [-Wdeprecated-declarations]
>>             [nsContext setView : nsView];
>>                        ^
>> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSOpenGL.h:193:36: note: property 'view' is dec...
>
> That's because we don't enable javac lint warnings by default. I am getting ready to file a few JBS issues related to this. Stay tuned.
> 
> In the mean time, if you want to see how many warnings we do have, try running with `gradle -PLINT=all`. Or rather, you'll see how many modules hit the 100 warnings limit. :)

So, that
@SuppressWarnings("serial") // Same-version serialization only
would be addressed as javac lint warning JBS?

Just thinking out aloud, I dont see this @SuppressWarnings("doclint:missing") in our java.desktop classes? what's the difference there?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1386#discussion_r1512059413