RFR: 8307980: Rotate Transformation never invalidates inverseCache

Lukasz Kostyra lkostyra at openjdk.org
Wed Mar 6 15:55:11 UTC 2024


Fixed as described in the issue + added tests to check for this scenario with all Transform sub classes. Since the test scenario slightly exceeding the regular parametrized testing of `TransformOperationsTest` I decided to implement the tests in a separate class.

I didn't manage to reproduce the issue with other Transform sub classes, so it seems to only affect `Rotate`. Also checked by looking at the code, only `Rotate` was affected by this bug. As such, without 08ba284 only `testTransformInverseCache_Rotate` fails, while others succeed. With the fix, all tests pass.

Ran the whole test suite afterwards and didn't notice any changes to test results after introducing the fix.

-------------

Commit messages:
 - Rotate: Invalidade inverse cache when transform changes
 - Add transform inverse tests

Changes: https://git.openjdk.org/jfx/pull/1392/files
 Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1392&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8307980
  Stats: 121 lines in 2 files changed: 121 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jfx/pull/1392.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1392/head:pull/1392

PR: https://git.openjdk.org/jfx/pull/1392


More information about the openjfx-dev mailing list