RFR: JDK-8285893: Hiding dialog and showing new one causes dialog to be frozen [v6]

Marius Hanl mhanl at openjdk.org
Thu Mar 7 21:54:58 UTC 2024


On Wed, 6 Mar 2024 17:24:10 GMT, Martin Fox <mfox at openjdk.org> wrote:

> The Mac is still failing the NestedEventLoop test.

Thanks for testing this on Mac. I always need to ask someone in order to test the changes, so really appreciating that.

> I've created a branch with my proposed fix for this problem (https://github.com/beldenfox/jfx/tree/eventloopjam). The fix prevents the dispatcher from jamming when the event loop it thought was leaving enters a new loop instead. Over in the Mac Glass code I also added a comment with a few more details on what's going on.

I tested your code and it looks good! So this seems to be the better approach here. While mine works for Windows and maybe Linux, it does not for Mac as you also specified.

The return value of the native nested event loops are still not needed, so we can still think about keeping this change, but we should probably revert the EventLoop changes and take your fix instead.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1324#issuecomment-1984564786


More information about the openjfx-dev mailing list