RFR: JDK-8322964 Optimize performance of CSS selector matching [v5]
John Hendrikx
jhendrikx at openjdk.org
Sat Mar 9 06:19:58 UTC 2024
On Sat, 9 Mar 2024 00:04:04 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Optimize performance of OpenAddressed Set just in case it is ever used
>
> modules/javafx.graphics/src/test/java/test/com/sun/javafx/css/BitSetTest.java line 160:
>
>> 158: //
>> 159: // assertNotEquals(set1, set2);
>> 160: // }
>
> should we remove the dead code?
Yeah, I guess we can -- it's unlikely we'll ever make another implementation of `BitSet` -- it's more likely that after this PR we may also do a similar change for `PseudoClassState` and remove `BitSet` completely :)
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1316#discussion_r1518488573
More information about the openjfx-dev
mailing list